WIP: implement ens-ponder as ens-v2 plugin for sepolia #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@shrugs what is the bug you mentioned in the PR description? |
shrugs
changed the title
There was a problem hiding this comment.
@shrugs Hey thanks for drafting this PR 👍 Reviewed and shared a few ideas with feedback.
| /** | ||
| * ENS v2 Isolated Schema | ||
| * | ||
| * NOTE: These entities kept namespaced for rapid prototyping—see v2 plans for additional context. |
There was a problem hiding this comment.
Suggested change
| * NOTE: These entities kept namespaced for rapid prototyping—see v2 plans for additional context. | |
| * NOTE: These entities for ensv2 are temporarily kept namespaced for rapid prototyping—see v2 plans for additional context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseded by #356
This PR integrates the indexing schema/logic from https://github.com/ensdomains/ens-ponder into ENSNode.
v2_in order to still serve a unified autogenerated graphql api and avoid naming collisions.@ensnode/ens-deploymentsens-v2pluginBlocked By
running into this indexing issue ensdomains/ens-ponder#1
Todo in future PRs: