Normalize labelhash for ENSRainbow Heal request #347
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ).rejects.toThrow("Invalid labelhash length 65 characters (expected 66)"); | ||
| labelByHash("0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0"), | ||
| ).rejects.toThrow( | ||
| 'Error healing labelhash: "0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0". Error (400): Invalid labelhash length: expected 32 bytes (64 hex chars), got 31 bytes: 0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0.', |
There was a problem hiding this comment.
should we make these errors non redundant?
There was a problem hiding this comment.
Sorry I don't understand the question. Please share more details.
There was a problem hiding this comment.
E.g. labelhash is written twice in this error. I think it should be just:
Error (400): Invalid labelhash length: expected 32 bytes (64 hex chars), got 31 bytes: 0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0.
There was a problem hiding this comment.
@djstrong Thanks for updates 👍 Reviewed and shared feedback
|
|
||
| export namespace EnsRainbow { | ||
| export type ApiClientOptions = EnsRainbowApiClientOptions; | ||
|
|
||
| export interface ApiClient { | ||
| count(): Promise<CountResponse>; | ||
|
|
||
| heal(labelhash: Labelhash): Promise<HealResponse>; | ||
| heal(labelhash: Labelhash | string): Promise<HealResponse>; |
There was a problem hiding this comment.
Please define a type for EncodedLabelhash
There was a problem hiding this comment.
I have created it for parseEncodedLabelhash but string needs to stay here because we accept unnormalized labelhashes.
| ).rejects.toThrow("Invalid labelhash length 65 characters (expected 66)"); | ||
| labelByHash("0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0"), | ||
| ).rejects.toThrow( | ||
| 'Error healing labelhash: "0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0". Error (400): Invalid labelhash length: expected 32 bytes (64 hex chars), got 31 bytes: 0x0ca5d0b4ef1129e04bfe7d35ac9def2f4f91daeb202cbe6e613f1dd17b2da0.', |
There was a problem hiding this comment.
Sorry I don't understand the question. Please share more details.
|
|
||
| export namespace EnsRainbow { | ||
| export type ApiClientOptions = EnsRainbowApiClientOptions; | ||
|
|
||
| export interface ApiClient { | ||
| count(): Promise<CountResponse>; | ||
|
|
||
| heal(labelhash: Labelhash): Promise<HealResponse>; | ||
| heal(labelhash: Labelhash | EncodedLabelhash | string): Promise<HealResponse>; |
There was a problem hiding this comment.
Or this should be just labelhash: string?
#211