Skip to content

Revert "Fix end in select in some cases was inclusive (#54)"#68

Merged
nakabonne merged 1 commit into
mainfrom
revert-54
Aug 6, 2025
Merged

Revert "Fix end in select in some cases was inclusive (#54)"#68
nakabonne merged 1 commit into
mainfrom
revert-54

Conversation

@nakabonne

Copy link
Copy Markdown
Owner

This reverts commit 7e4b396.

Unit tests are failing. We'll figure this out later

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.45%. Comparing base (6ca1faf) to head (d20d36b).
⚠️ Report is 6 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   62.00%   60.45%   -1.54%     
==========================================
  Files          19       19              
  Lines        1134     1613     +479     
==========================================
+ Hits          703      975     +272     
- Misses        296      502     +206     
- Partials      135      136       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nakabonne nakabonne merged commit 64a7605 into main Aug 6, 2025
4 checks passed
@nakabonne nakabonne deleted the revert-54 branch August 6, 2025 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants