-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature swap file #42
Conversation
- Change the way we get the recordings items in RecyclerView - Change DatabaseListener for new entries from recyclerView to Fragment. - Add Multiple interface for touch event - Create a custom ItemTouchHelperCallback for handle drag and drop Issues #23
- Update Rename item listener - Update the ReecyclerView properly when item renamed or deleted
- Add code - Clean some commented code
Thank you for your contribution! I'll review it in the next few days.
|
@axel-legue you've implemented records reordering and it's working fine. After manual testing I discovered the following issues:
Possible solutions:
Please fix the first two issues and then I review this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the above suggestions or explain why not
closing stale PR |
It's my first contribution to an Open Source Project,
So let me know if i do something wrong.