-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address build warnings about ncurses example #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
According to the example's comment,
If it is true, I think this needs to be updated to say * NOTE: RF24MESH_DEBUG MUST BE DISABLED IN RF24Mesh_config.h I also noticed that every time I run this example without a pre-existing dhcplist.txt, a non-existent child node of ID 8 was assigned the address 01. This doesn't happen in pyrf24 package, so I think this is related to a recent change (or somehow specific to this example). |
I found it.
I suppose this is expected behavior given the above example-specific code. |
Hmm, I thought we'd removed that line from all the examples. It should be removed, an old artifact from testing.
Agreed. Can you add these changes to this PR? |
I've already updated the intro comment. I'll remove that line about setting a static address. |
resolves #241 * update example intro comment * remove static address assignment in example
cherry picked to v1.x |
resolves #241