Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address build warnings about ncurses example #243

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 18, 2024

resolves #241

Copy link
Member

@TMRh20 TMRh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@2bndy5
Copy link
Member Author

2bndy5 commented Jun 20, 2024

According to the example's comment,

* NOTE: DEBUG MUST BE DISABLED IN RF24Mesh_config.h

If it is true, I think this needs to be updated to say

  * NOTE: RF24MESH_DEBUG MUST BE DISABLED IN RF24Mesh_config.h 

I also noticed that every time I run this example without a pre-existing dhcplist.txt, a non-existent child node of ID 8 was assigned the address 01.

This doesn't happen in pyrf24 package, so I think this is related to a recent change (or somehow specific to this example).

@2bndy5
Copy link
Member Author

2bndy5 commented Jun 20, 2024

I also noticed that every time I run this example without a pre-existing dhcplist.txt, a non-existent child node of ID 8 was assigned the address 01.

I found it.

mesh.setStaticAddress(8, 01);

I suppose this is expected behavior given the above example-specific code.

@TMRh20
Copy link
Member

TMRh20 commented Jun 21, 2024

mesh.setStaticAddress(8, 01);

I suppose this is expected behavior given the above example-specific code.

Hmm, I thought we'd removed that line from all the examples. It should be removed, an old artifact from testing.

If it is true, I think this needs to be updated to say

  * NOTE: RF24MESH_DEBUG MUST BE DISABLED IN RF24Mesh_config.h 

Agreed. Can you add these changes to this PR?

@2bndy5
Copy link
Member Author

2bndy5 commented Jun 21, 2024

I've already updated the intro comment. I'll remove that line about setting a static address.

@2bndy5 2bndy5 merged commit 3d26ba7 into master Jun 21, 2024
9 checks passed
@2bndy5 2bndy5 deleted the address-build-warnings branch June 21, 2024 21:48
2bndy5 added a commit that referenced this pull request Jun 21, 2024
resolves #241

* update example intro comment
* remove static address assignment in example
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 21, 2024

cherry picked to v1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address build warnings in ncurses example
2 participants