Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out setStaticAddress in example #27

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Comment out setStaticAddress in example #27

merged 1 commit into from
Feb 16, 2024

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Feb 16, 2024

This line can be a source of confusion if left enabled as it adds a static node on the master node, but can cause a segfault if called on non-master node

This line can be a source of confusion if left enabled as it adds a static node on the master node, but can cause a segfault if called on non-master node
@2bndy5
Copy link
Member

2bndy5 commented Feb 16, 2024

can cause a segfault if called on non-master node

Woah! Is there something we should do to prevent that?

@2bndy5
Copy link
Member

2bndy5 commented Feb 16, 2024

Damn it! CI is broken because actions/upload-artifact@v4 does not allow uploading different files under the same artifact name (as was supported in v3)... I'll have to update that reusable workflow as well (in org repo).

EDIT: I fixed this. CI should run smoothly now

@TMRh20
Copy link
Member Author

TMRh20 commented Feb 16, 2024

Thanks!

Woah! Is there something we should do to prevent that?

Yeah, the code should be modified to prevent it, but the line in the example was from initial testing years ago, so kind of an annoyance. I figured its a quick workaround and I can look at a proper fix later.

@2bndy5
Copy link
Member

2bndy5 commented Feb 16, 2024

I figured its a quick workaround and I can look at a proper fix later

Maybe open an issue as a reminder then?

@TMRh20
Copy link
Member Author

TMRh20 commented Feb 16, 2024

Done

@TMRh20 TMRh20 merged commit 8f58e13 into master Feb 16, 2024
16 checks passed
@TMRh20 TMRh20 deleted the ExamplesChanges branch February 16, 2024 11:51
2bndy5 added a commit that referenced this pull request Jun 11, 2024
This line can be a source of confusion if left enabled as it adds a static node on the master node, but can cause a segfault if called on non-master node
@2bndy5
Copy link
Member

2bndy5 commented Jun 11, 2024

cherry-picked this change to v1.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants