-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang format #940
Update clang format #940
Conversation
I'll also rebase the GPIO_Changes branch after this is merged. |
Woah, 4 reviews from 1 push?! I need to change how many times clang-format is run in a single CI run. Currently it runs once per platform build (PIO, Arduino, Linux, PicoSDK). |
currently too much headache from upstream problems (namely in Arduino CLI tool)
to update CI dependencies
Too many CI jobs generated... Merging this should significantly reduce the number of jobs triggered. Also pushing a commit on a branch that is not used for releases should no longer trigger a CI run. Instead, the CI should only trigger on commits pushed to branches with an open PR or pushes directly to master branches (& 1.x branch for net layers). There are a lot of jobs for this PR because it is running the CI config from master branch and as well as CI changes for this branch. Its all really confusing (& annoying to me). |
#### NOTE installing ATTinyCore has become too problematic for various reasons | ||
#### I'll have to revisit this later when the Arduino CLI tool gets their act together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is disappointing, but I can't keep waiting for Arduino CLI to fix problems with installing third-party cores. Lately, if it isn't one problem then it is another problem.
Hopefully in a few months (or before our next release) I'll remember to check up on this. From what I can tell, the problem(s) can be reproduced locally without a CI runner...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change basically mens we won't be getting compile size delta summary for our ATTiny examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
No concerns from clang-format.
Great job! 🎉
Have any feedback or feature suggestions? Share it here.
Memory usage change @ b68ee10
Click for full report table
Click for full report CSV
|
nRF24/.github#9