Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang format #940

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Update clang format #940

merged 8 commits into from
Feb 17, 2024

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Feb 16, 2024

github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 16, 2024 13:42

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 16, 2024 13:42

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 16, 2024 13:42

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@2bndy5
Copy link
Member Author

2bndy5 commented Feb 16, 2024

I'll also rebase the GPIO_Changes branch after this is merged.

@2bndy5
Copy link
Member Author

2bndy5 commented Feb 16, 2024

Woah, 4 reviews from 1 push?! I need to change how many times clang-format is run in a single CI run. Currently it runs once per platform build (PIO, Arduino, Linux, PicoSDK).

@github-actions github-actions bot dismissed their stale review February 16, 2024 15:03

outdated suggestion

github-actions[bot]

This comment was marked as outdated.

currently too much headache from upstream problems (namely in Arduino CLI tool)
@github-actions github-actions bot dismissed their stale review February 16, 2024 15:16

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@github-actions github-actions bot dismissed their stale review February 16, 2024 15:33

outdated suggestion

github-actions[bot]

This comment was marked as duplicate.

@2bndy5
Copy link
Member Author

2bndy5 commented Feb 16, 2024

Too many CI jobs generated... Merging this should significantly reduce the number of jobs triggered. Also pushing a commit on a branch that is not used for releases should no longer trigger a CI run. Instead, the CI should only trigger on commits pushed to branches with an open PR or pushes directly to master branches (& 1.x branch for net layers).

There are a lot of jobs for this PR because it is running the CI config from master branch and as well as CI changes for this branch. Its all really confusing (& annoying to me).

Comment on lines +111 to +112
#### NOTE installing ATTinyCore has become too problematic for various reasons
#### I'll have to revisit this later when the Arduino CLI tool gets their act together
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is disappointing, but I can't keep waiting for Arduino CLI to fix problems with installing third-party cores. Lately, if it isn't one problem then it is another problem.

Hopefully in a few months (or before our next release) I'll remember to check up on this. From what I can tell, the problem(s) can be reproduced locally without a CI runner...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change basically mens we won't be getting compile size delta summary for our ATTiny examples.

@github-actions github-actions bot dismissed their stale review February 17, 2024 10:52

outdated suggestion

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

No concerns from clang-format.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

Copy link
Contributor

Memory usage change @ b68ee10

Board flash % RAM for global variables %
arduino:avr:nano 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/GettingStarted
flash
% examples/GettingStarted
RAM for global variables
% examples/AcknowledgementPayloads
flash
% examples/AcknowledgementPayloads
RAM for global variables
% examples/ManualAcknowledgements
flash
% examples/ManualAcknowledgements
RAM for global variables
% examples/StreamingData
flash
% examples/StreamingData
RAM for global variables
% examples/MulticeiverDemo
flash
% examples/MulticeiverDemo
RAM for global variables
% examples/InterruptConfigure
flash
% examples/InterruptConfigure
RAM for global variables
% examples/scanner
flash
% examples/scanner
RAM for global variables
% examples/encodeRadioDetails
flash
% examples/encodeRadioDetails
RAM for global variables
%
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/GettingStarted<br>flash,%,examples/GettingStarted<br>RAM for global variables,%,examples/AcknowledgementPayloads<br>flash,%,examples/AcknowledgementPayloads<br>RAM for global variables,%,examples/ManualAcknowledgements<br>flash,%,examples/ManualAcknowledgements<br>RAM for global variables,%,examples/StreamingData<br>flash,%,examples/StreamingData<br>RAM for global variables,%,examples/MulticeiverDemo<br>flash,%,examples/MulticeiverDemo<br>RAM for global variables,%,examples/InterruptConfigure<br>flash,%,examples/InterruptConfigure<br>RAM for global variables,%,examples/scanner<br>flash,%,examples/scanner<br>RAM for global variables,%,examples/encodeRadioDetails<br>flash,%,examples/encodeRadioDetails<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@2bndy5 2bndy5 merged commit 4b7ab9c into master Feb 17, 2024
182 checks passed
@2bndy5 2bndy5 deleted the update-clang-format branch February 17, 2024 11:59
@2bndy5 2bndy5 restored the update-clang-format branch February 22, 2024 06:53
@2bndy5 2bndy5 deleted the update-clang-format branch February 22, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant