Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to clang-format v14 #11

Merged
merged 5 commits into from
Feb 16, 2024
Merged

switch to clang-format v14 #11

merged 5 commits into from
Feb 16, 2024

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Feb 4, 2024

Updates reusable CI workflow that checks code formatting.

  • uses clang-format v16
  • uses bleeding edge of cpp-linter package to field-test the new PR review feature (cpp-linter --format-review).

Also updates the guideline explanations as some (useful) options were only applicable to v13+.

Note

Updates to all nRF24 org repo's .clang-format file is required for consistency.

closes #9

@2bndy5
Copy link
Member Author

2bndy5 commented Feb 4, 2024

the new PR review feature

This feature (of cpp-linter python package) will produce a PR review with a patch (to fix format problems) in the review's summary comment and include applicable fixes as suggestions in review comments (specific to lines in the PR diff).

@TMRh20 This one is for you mostly, but it will be a help to anyone that doesn't understand what the CI is trying to say about code formatting.

PS - Having the CI fix formatting and push changes automatically is on my radar (for the cpp-linter pkg), but I have to be mindful of the write access that idea requires.

@2bndy5 2bndy5 force-pushed the update-clang-format branch 2 times, most recently from 7e32683 to 71f417d Compare February 16, 2024 10:51
@2bndy5 2bndy5 changed the title switch to clang-format v17 switch to clang-format v16 Feb 16, 2024
@2bndy5 2bndy5 force-pushed the update-clang-format branch from e544d35 to e5f6af0 Compare February 16, 2024 11:30
uses cpp-linter v1.7.1 for the new PR review feature (`--format-review` arg)

cpp-linter needs a token to post PR reviews/comments
@2bndy5 2bndy5 force-pushed the update-clang-format branch from e5f6af0 to 7846dea Compare February 16, 2024 11:31
@2bndy5 2bndy5 changed the title switch to clang-format v16 switch to clang-format v14 Feb 16, 2024
@2bndy5
Copy link
Member Author

2bndy5 commented Feb 16, 2024

I'm ready to merge this, but I want to wait till nRF24/RF24Network#218 is merged first. pushing this change to main will also instigate a crusade of PRs to update the .clang-format config files in all repos.

I have created branches in all repos for the upcoming format crusade.

@2bndy5 2bndy5 merged commit df74ab7 into main Feb 16, 2024
@2bndy5 2bndy5 deleted the update-clang-format branch February 16, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update clang-format to use v14
1 participant