Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix shortcut issue on save buttons #9309

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 6, 2024

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 6, 2024
Copy link

cypress bot commented May 7, 2024

1 flaky test on run #4878 ↗︎

0 359 12 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: ec99d188b9
Status: Passed Duration: 04:27 💡
Started: May 7, 2024 7:01 AM Ended: May 7, 2024 7:05 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Screenshots Video

Review all test suite changes for PR #9309 ↗︎

Copy link
Contributor

github-actions bot commented May 7, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit e74c14f into master May 7, 2024
28 checks passed
@ivov ivov deleted the pay-1555-on-the-credential-save-button-we-show-the-keyboard-shortcut branch May 7, 2024 07:09
@github-actions github-actions bot mentioned this pull request May 8, 2024
@janober
Copy link
Member

janober commented May 8, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants