Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix type errors in the SettingsLdapView.vue (no-changelog) #9308

Merged

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented May 6, 2024

Summary

This PR decreases the type errors in the FE from 1712 to 1688.

To test locally build n8n with export ENABLE_TYPE_CHECKING=true

Related tickets and issues

https://linear.app/n8n/issue/ADO-2207/fix-type-errors-in-settingsldapviewvue

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)

@RicardoE105 RicardoE105 changed the title fix(editor): Fix type errors in the SettingsLdapView.vue fix(editor): Fix type errors in the SettingsLdapView.vue (no-changelog) May 6, 2024
@RicardoE105 RicardoE105 changed the title fix(editor): Fix type errors in the SettingsLdapView.vue (no-changelog) fix(editor): Fix type errors in the SettingsLdapView.vue (no-changelog) May 6, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 6, 2024
@RicardoE105 RicardoE105 requested review from mutdmour and removed request for alexgrozav May 6, 2024 13:50
Copy link

cypress bot commented May 6, 2024

Passing run #4870 ↗︎

0 359 12 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project: n8n Commit: cf651dd5c5
Status: Passed Duration: 04:11 💡
Started: May 6, 2024 2:31 PM Ended: May 6, 2024 2:35 PM

Review all test suite changes for PR #9308 ↗︎

Copy link
Contributor

github-actions bot commented May 6, 2024

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 552cf8f into master May 6, 2024
35 checks passed
@RicardoE105 RicardoE105 deleted the ado-2207-fix-type-errors-in-settingsldapviewvue branch May 6, 2024 15:20
@janober
Copy link
Member

janober commented May 8, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants