Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RBAC UX tweaks #9303

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@cstuncsik cstuncsik marked this pull request as ready for review May 3, 2024 13:49
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 3, 2024
Copy link

cypress bot commented May 3, 2024

8 failed and 3 flaky tests on run #4861 ↗︎

8 352 12 0 Flakiness 3

Details:

🌳 pay-1513-update-owner-details-sharing-on-workflow-cards-home-layout 🖥️ brows...
Project: n8n Commit: 5e271de437
Status: Failed Duration: 05:46 💡
Started: May 3, 2024 3:14 PM Ended: May 3, 2024 3:19 PM
Failed  cypress/e2e/17-sharing.cy.ts • 8 failed tests

View Output Video

Test Artifacts
Sharing > should create C1, W1, W2, share W1 with U3, as U2 Test Replay Screenshots Video
Sharing > should create C2, share C2 with U1 and U2, as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U3 Test Replay Screenshots Video
Sharing > should open W1, add node using C2 as U2 Test Replay Screenshots Video
Sharing > should not have access to W2, as U3 Test Replay Screenshots Video
Sharing > should have access to W1, W2, as U1 Test Replay Screenshots Video
Sharing > should automatically test C2 when opened by U2 sharee Test Replay Screenshots Video
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video
Flakiness  39-projects.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Projects > should handle workflows and credentials Test Replay Screenshots Video
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
NDV > Stop listening for trigger event from NDV Test Replay Screenshots Video

Review all test suite changes for PR #9303 ↗︎

@cstuncsik cstuncsik merged commit 1581dc2 into feature/rbac May 6, 2024
27 of 29 checks passed
@cstuncsik cstuncsik deleted the pay-1513-update-owner-details-sharing-on-workflow-cards-home-layout branch May 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant