Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove gulp (no-changelog) #9283

Merged
merged 3 commits into from May 6, 2024
Merged

ci: Remove gulp (no-changelog) #9283

merged 3 commits into from May 6, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented May 2, 2024

Gulp was single-handedly responsible for pulling in almost all deprecated packages in the dependency tree. Removing gulp trims down the dev-dependency tree quite a lot.

Related tickets and issues

N8N-4457

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label May 2, 2024
@netroy netroy changed the title ci: Upgrade gulp (no-changelog) ci: Remove gulp (no-changelog) May 6, 2024
ivov
ivov previously approved these changes May 6, 2024
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested icons and i18n, both working. Thanks for this!

Copy link

cypress bot commented May 6, 2024

1 flaky test on run #4877 ↗︎

0 359 12 0 Flakiness 1

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: cf441e0294
Status: Passed Duration: 04:10 💡
Started: May 7, 2024 3:11 AM Ended: May 7, 2024 3:15 AM
Flakiness  cypress/e2e/17-workflow-tags.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Workflow tags > should create and attach tags inline Test Replay Screenshots Video

Review all test suite changes for PR #9283 ↗︎

Copy link
Contributor

github-actions bot commented May 6, 2024

✅ All Cypress E2E specs passed

Copy link
Contributor

github-actions bot commented May 6, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit cf441e0 into master May 6, 2024
28 checks passed
@netroy netroy deleted the upgrade-gulp branch May 6, 2024 16:42
@janober
Copy link
Member

janober commented May 8, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants