Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add item selector to expression output #9281

Merged
merged 13 commits into from May 9, 2024
Merged

feat(editor): Add item selector to expression output #9281

merged 13 commits into from May 9, 2024
+313 −98

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented May 2, 2024 •
edited

Summary

image

Related tickets and issues

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels May 2, 2024
cstuncsik
cstuncsik previously approved these changes May 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented May 9, 2024 •
edited

1 flaky test on run #4917 ↗︎

0 360 12 0 Flakiness 1

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: dc5994b185
Status: Passed Duration: 04:22 💡
Started: May 10, 2024 3:11 AM Ended: May 10, 2024 3:15 AM
Flakiness  cypress/e2e/17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sharing > should work for admin role on credentials created by others (also can share it with themselves) Test Replay Screenshots Video

Review all test suite changes for PR #9281 ↗︎

@elsmr elsmr requested a review from cstuncsik May 9, 2024 09:46
cstuncsik
cstuncsik previously approved these changes May 9, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

✅ All Cypress E2E specs passed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit dc5994b into master May 9, 2024
32 checks passed
@elsmr elsmr deleted the item-selector-expression-output branch May 9, 2024 12:45
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
@janober
Copy link
Member

janober commented May 15, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elsmr @janober @cstuncsik