New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HTTP request tool #9228
Open
michael-radency
wants to merge
29
commits into
master
Choose a base branch
from
ai-162-tool-to-visit-a-website
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: HTTP request tool #9228
+1,302
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol-to-visit-a-website
michael-radency
added
node/new
Creation of an entirely new node
n8n team
Authored by the n8n team
labels
Apr 26, 2024
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
…ol-to-visit-a-website
netroy
reviewed
May 1, 2024
); | ||
} | ||
const returnData: string[] = []; | ||
const html = cheerio.load(response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use @mozilla/readability
and jsdom
here to cleanly extract the content that's likely relevant to an end-user.
Something like this perhaps:
import { JSDOM } from 'jsdom'
import { Readability } from '@mozilla/readability'
const dom = await JSDOM.fromURL(url)
const article = new Readability(dom.window.document, {
keepClasses: true,
}).parse()
and then use article.content
.
we could also consider using turndown to convert the html into markdown, which LLM tend to handle better than html IMO.
import Turndown from 'turndown'
const markdown = turndown.turndown(article.content)
…ol-to-visit-a-website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tool to visit a website
Related tickets and issues
https://linear.app/n8n/issue/AI-162/tool-to-visit-a-website