perf(core): Introduce backend performance benchmarking #9199
+1,071
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
force-pushed
the
codspeed-tinybench
branch
from
7adada8
to
b40652d
Compare
ivov
commented
May 2, 2024
| @@ -167,7 +167,7 @@ export abstract class AbstractServer { | |||
|
|
|||
| await this.setupHealthCheck(); | |||
|
|
|||
| console.log(`n8n ready on ${ADDRESS}, port ${PORT}`); | |||
| this.logger.info(`n8n ready on ${ADDRESS}, port ${PORT}`); | |||
There was a problem hiding this comment.
Logging changes like these ensure N8N_LOG_LEVEL=silent mutes this logging noise during benchmarking runs.
ivov
commented
May 2, 2024
Comment on lines
+10
to
+15
| + let uri = `${callingFile}::${name}`; | ||
| + if (name.includes('::')) { | ||
| + // ignore calling file misdirecting to benchmark/lib/api.js | ||
| + const [suiteName, taskName] = name.split('::'); | ||
| + uri = `${suiteName} - ${taskName}` | ||
| + } |
There was a problem hiding this comment.
Ensure suite name is shown instead of packages/cli/dist/benchmark/lib/api.js.
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
|
To check after this is in master:
|
|
Closing due to excessive variance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tinybench and Codspeed to benchmark changes to backend performance (execution time) and report improvements or regressions via CI.
Context: https://www.notion.so/n8n/Performance-benchmarking-6b66f7bf672b467a9763f81df789b08d