Pin to the latest compatibility date for Cloudflare workers #2237
Conversation
This change applies to the kv-response-cache plugin
🦋 Changeset detectedLatest commit: e5e197c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great ! Thank you for the PR! |
| @@ -1,5 +1,5 @@ | |||
| import type { ExecutionResult } from 'graphql'; | |||
| import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types'; | |||
| import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types/2023-07-01'; | |||
There was a problem hiding this comment.
Doesn't this have the potential to age poorly ? We will have to update all imports when we update the types dependency ?
|
@AdiRishi We also have another PR (#2238) which should even remove the necessity to have a type matching on user land. This PR doesn't take any CFW types anymore and takes the namespace name as string instead. Which both simplify the usage and should fix the type issue :-) But I still think we should pin the typing anyway |
This change applies to the kv-response-cache plugin
Description
The
@cloudflare/worker-typespackage has multiple versions of its types that are pinned to different compatibility dates. The When you create a new cloudflare project using their CLI, they now default to the latest date whcih is2023-07-01.This PR updates the imports for the kv response cache plugin to use the name compatibility dates as the default for new projects, this should incraese compatibility for users.
For issue #2104
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing this is a bit challenging. The types are correct locally, the hope is that when this package is imported there will be fewer conflicts with types.
Checklist:
CONTRIBUTING doc and the
style guidelines of this project