Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useApolloInlineTrace plugin for Apollo's federated tracing #1490

Open
wants to merge 11 commits into
base: perform
Choose a base branch
from

Conversation

enisdenjo
Copy link
Collaborator

@enisdenjo enisdenjo commented Aug 18, 2022

Closes #1489

  • Manipulate the final result extensions field on parsing and validation errors (see failing tests)

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022

🦋 Changeset detected

Latest commit: f8691e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/apollo-inline-trace Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 18, 2022

@enisdenjo is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@enisdenjo enisdenjo force-pushed the use-inline-trace-plugin branch from db70142 to 638351e Compare September 13, 2022 10:37
@enisdenjo enisdenjo marked this pull request as ready for review September 13, 2022 11:20
@YassinEldeeb
Copy link
Collaborator

the core tests are failing for some reason

@Arno500
Copy link

Arno500 commented Sep 2, 2023

Any update on this one?

@enisdenjo
Copy link
Collaborator Author

@Arno500 this one cannot be merged before #1493 is handled (because parsing and validation errors cannot be manipulated currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apollo's federated inline tracing plugin
5 participants