Fix bugs in the process of opening a new path #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ignoring unrelated lint failure |
divagant-martian
merged commit d801c3e
into
n0-computer:multipath-quinn-0.11.x
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs,
PathData::validatedshould always be true for clients. There's nowhere in the code wherevalidatedis originally set based on connection side, and the docs also mention ause_stateless_retrythat no longer exists (not even on upstream). So, I don't trust these docs. Because of this I find it preferable to externally add the check of sideAlso adds some fields for debugging when we are creating packet number spaces by default. So far I see we are creating both initial and handshake spaces for multipaths.