Utilize spatial queries to retrieve gyms within SCAN_AREA on raidscan init#26
Open
hokiepokedad2 wants to merge 4 commits intomzsmakr:masterfrom
Open
Utilize spatial queries to retrieve gyms within SCAN_AREA on raidscan init#26hokiepokedad2 wants to merge 4 commits intomzsmakr:masterfrom
hokiepokedad2 wants to merge 4 commits intomzsmakr:masterfrom
Conversation
…rea instead of all gyms on raidscan start.
hokiepokedad2
changed the title
|
Just tested this PR on a MySQL DB, and it works perfectly. what took more than 2hrs for 45k gyms, now only takes less than 30 seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on RaidScan.init, all forts are retrieved from the database and are checked to see if they are within the SCAN_AREA polygon/boundaries. For implementations where there is a large number of forts in the database, this process proved to be excruciatingly slow and took near 45 minutes to begin control for approximately 47k forts.
Spatial queries will instead be used to retrieve forts ONLY within the SCAN_AREA polygon/boundaries. Depending on how large the SCAN_AREA is, startup went from ~45 minutes to about 5 seconds.
For PostgreSQL implementations, please install PostGIS and create the extension for your monocle database (https://postgis.net/).
MySQL implementations should support spatial queries natively.