Open
Conversation
Collaborator
|
maybe rename maybe also legacy support for |
M4d40
suggested changes
Aug 31, 2018
M4d40
left a comment
There was a problem hiding this comment.
Better add the string check and transform it if needed to a list.
That way both WEBHOOKS are valid.
A Single one as String and also a List.
(Also that way it is backwards compatible)
raidnearby.py
Outdated
| headers={'Content-Type': 'application/json'} | ||
| ) | ||
| LOG.info('Webhook is send.') | ||
| for wh in self.config.WEBHOOK: |
There was a problem hiding this comment.
conf_webhook = self.config.WEBHOOK
if isinstance(conf_webhook , str):
conf_webhook = [conf_webhook ]
for wh in conf_webhook:
Author
|
How about something like this in order to add legacy support? @123FLO321 or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for multiple webhook endpoints.
Example use is I use a Discord bot and a PokeAlarm instance.