Skip to content

CMake: add missing mbedtls libraries in shared library target #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v1.6
Choose a base branch
from

Conversation

stv0g
Copy link
Contributor

@stv0g stv0g commented Jul 16, 2025

No description provided.

Copy link

@pjungkamp
Copy link

The changes on GitHub indicate that the whole file was edited because this PR changes the line endings from LF to CRLF.

There are actually several more files in this repository that use an inconsistent line ending style. I analyzed all files in this repository using file to check for CRLF line endings.

CRLF line ending by extension
extension (crlf/total)
.0 0/2
.6 0/2
.asn 0/1
.c 2/269
.cer 0/4
.cfg 0/6
.cid 12/16
.classpath 0/1
.cmake 0/2
.config 0/1
.cs 9/57
.csproj 4/36
.css 0/3
.direnv 0/1
.doxygen 0/1
.envrc 0/1
.git 0/1
.github 0/1
.gitignore 0/1
.h 4/196
.hpp 0/6
.html 0/2
.i 0/1
.icd 11/12
.ico 0/1
.idx 0/1
.iid 1/1
.in 0/4
.jar 0/4
.java 0/53
.key 0/3
.md 0/4
.mf 4/4
.mk 0/3
.pack 0/1
.patch 0/1
.pem 0/9
.png 0/1
.prefs 0/1
.project 0/1
.py 0/3
.rev 0/1
.sample 0/14
.scd 2/2
.settings 0/1
.sh 0/4
.sln 1/2
.standalone 0/2
.txt 2/54
.xml 0/1
.yml 0/4

There are notable inconsistencies in the .c, .h, .txt, and .cs files. Other files like .cid, .icd, .sln and .csproj are also affected but are likely in part machine generated.

Git has the ability to automatically fix this for the entire repository. https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings

@pbsds
Copy link

pbsds commented Jul 17, 2025

The "hide whitespace changes" view is a lot easier to read: https://github.com/mz-automation/libiec61850/pull/557/files?w=1 (i'm not arguing in favor of converting the whole file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants