Set TableHeaderColumnSpanHandling to true by default

mysticmind · Jun 18, 2024 · f06581c · f06581c
1 parent 9f17786
commit f06581c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -19,15 +19,15 @@ If you have used and benefitted from this library. Please feel free to buy me a
 Install the package from NuGet using `Install-Package ReverseMarkdown` or clone the repository and built it yourself.
 
 <!-- snippet: Usage -->
-<a id='snippet-usage'></a>
+<a id='snippet-Usage'></a>
 ```cs
 var converter = new ReverseMarkdown.Converter();
 
 string html = "This a sample <strong>paragraph</strong> from <a href=\"http://test.com\">my site</a>";
 
 string result = converter.Convert(html);
 ```
-<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L11-L19' title='Snippet source file'>snippet source</a> | <a href='#snippet-usage' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L11-L19' title='Snippet source file'>snippet source</a> | <a href='#snippet-Usage' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 Will result in:
@@ -43,7 +43,7 @@ This a sample **paragraph** from [my site](http://test.com)
 The conversion can be customized:
 
 <!-- snippet: UsageWithConfig -->
-<a id='snippet-usagewithconfig'></a>
+<a id='snippet-UsageWithConfig'></a>
 ```cs
 var config = new ReverseMarkdown.Config
 {
@@ -59,7 +59,7 @@ var config = new ReverseMarkdown.Config
 
 var converter = new ReverseMarkdown.Converter(config);
 ```
-<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L27-L43' title='Snippet source file'>snippet source</a> | <a href='#snippet-usagewithconfig' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L27-L43' title='Snippet source file'>snippet source</a> | <a href='#snippet-UsageWithConfig' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ## Configuration options

diff --git a/README.source.md b/README.source.md
@@ -12,15 +12,15 @@ If you have used and benefitted from this library. Please feel free to buy me a
 Install the package from NuGet using `Install-Package ReverseMarkdown` or clone the repository and build it yourself.
 
 <!-- snippet: Usage -->
-<a id='snippet-usage'></a>
+<a id='snippet-Usage'></a>
 ```cs
 var converter = new ReverseMarkdown.Converter();
 
 string html = "This a sample <strong>paragraph</strong> from <a href=\"http://test.com\">my site</a>";
 
 string result = converter.Convert(html);
 ```
-<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L11-L19' title='Snippet source file'>snippet source</a> | <a href='#snippet-usage' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L11-L19' title='Snippet source file'>snippet source</a> | <a href='#snippet-Usage' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 Will result in:
@@ -36,7 +36,7 @@ This a sample **paragraph** from [my site](http://test.com)
 The conversion can also be customized:
 
 <!-- snippet: UsageWithConfig -->
-<a id='snippet-usagewithconfig'></a>
+<a id='snippet-UsageWithConfig'></a>
 ```cs
 var config = new ReverseMarkdown.Config
 {
@@ -52,7 +52,7 @@ var config = new ReverseMarkdown.Config
 
 var converter = new ReverseMarkdown.Converter(config);
 ```
-<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L27-L43' title='Snippet source file'>snippet source</a> | <a href='#snippet-usagewithconfig' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/ReverseMarkdown.Test/Snippets.cs#L27-L43' title='Snippet source file'>snippet source</a> | <a href='#snippet-UsageWithConfig' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 ## Configuration options

diff --git a/src/ReverseMarkdown.Test/ConverterTests.cs b/src/ReverseMarkdown.Test/ConverterTests.cs
@@ -1359,8 +1359,7 @@ public Task WhenTable_WithColSpan_TableHeaderColumnSpansHandling_ThenConvertToGF
 
             var config = new Config
             {
-                UnknownTags = Config.UnknownTagsOption.Bypass,
-                TableHeaderColumnSpanHandling = true
+                UnknownTags = Config.UnknownTagsOption.Bypass
             };
             return CheckConversion(html, config);
         }

diff --git a/src/ReverseMarkdown/Config.cs b/src/ReverseMarkdown/Config.cs
@@ -81,7 +81,7 @@ public enum TableWithoutHeaderRowHandlingOption
         /// <summary>
         /// Set this flag to handle table header column with column spans
         /// </summary>
-        public bool TableHeaderColumnSpanHandling { get; set; } = false;
+        public bool TableHeaderColumnSpanHandling { get; set; } = true;
 
 
         /// <summary>