MariaDB test correction #2442
Open
MariaDB test correction #2442
+212
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change statistics test (mariadb doesn't have flush_tables) change load data infile disable (MariaDB return a specific error 4166 : ER_LOAD_INFILE_CAPABILITY_DISABLED) ensure load data is enable server side (mysql 8/mariadb 10.5)
rusher
changed the title
Closed
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks @rusher for setting me on the right track. https://github.com/MariaDB/mariadb.org-tools/blob/master/buildbot.mariadb.org/dockerfiles/ecofiles/test-mysqljs.sh#L43-L56 is the changes to integration tests that I needed to do to get it successful on all mariadb versions (CI tests: https://buildbot.mariadb.org/#/builders/123). As such test-statistics.js needs a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change statistics test (mariadb doesn't have flush_tables)
change load data infile disable (MariaDB return a specific error 4166 : ER_LOAD_INFILE_CAPABILITY_DISABLED)
ensure load data is enable server side (mysql 8/mariadb 10.5)