Scorecards 2023 - Privacy policy page #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascumsille
force-pushed
the
503-privacy-policy
branch
from
1d36f4e
to
17bfd19
Compare
zarino
approved these changes
Oct 4, 2023
| @@ -47,6 +47,10 @@ class LogoutView(LogoutView): | |||
| next_page = "scoring:home" | |||
|
|
|||
|
|
|||
| class PrivacyView(TemplateView): | |||
| template_name = "scoring/privacy.html" | |||
There was a problem hiding this comment.
I think you’ll want to set the page_title context variable, so that the <title> tag in the <head> gets populated?
def get_context_data(self, **kwargs):
context = super().get_context_data(**kwargs)
context["page_title"] = "Privacy policy"
return context
lucascumsille
force-pushed
the
503-privacy-policy
branch
from
17bfd19
to
beb2584
Compare
lucascumsille
force-pushed
the
503-privacy-policy
branch
from
beb2584
to
89e926d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #503
Preview here:
Screen.Recording.2023-10-04.at.10.49.41.mov