Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apache Thrift 0.18.1 runtime libraries. #2924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hdclark
Copy link

@hdclark hdclark commented Dec 2, 2022

Please read http://mxe.cc/#creating-packages

In particular, make sure that your build rules:

  • install .pc file,
  • install bin/test-pkg.exe compiled with flags by pkg-config,
  • install .dll to bin/ and .a, .dll.a to lib/,
  • use $(TARGET)-cmake instead of cmake,
  • build in $(BUILD_DIR) instead of $(SOURCE_DIR),
  • do not run target executables with Wine,
  • do not download anything while building,
  • do not install documentation,
  • do not install .exe files except test and build systems,

and .patch files are generated by tools/patch-tool-mxe.

If you add a package, you can use tool tools/skeleton.py.

Thanks!

@hdclark
Copy link
Author

hdclark commented Dec 2, 2022

This commit adds Apache Thrift RPC v0.17.0 runtime libraries (note: not the thrift compiler).

The build stage includes a minor 'dynamic patch' to fix Windows case-insensitivity. An upstream patch has been proposed, see apache/thrift#2649 .

@hdclark
Copy link
Author

hdclark commented Dec 2, 2022

Also note that I'm planning to use this for DICOMautomaton, which already uses MXE for Windows builds. (Thanks!!)

Reference issue tracking Thrift additions for DICOMautomaton: hdclark/DICOMautomaton#21

@hdclark
Copy link
Author

hdclark commented Dec 8, 2022

@mabrand: is this something you could take a look at?

@hdclark
Copy link
Author

hdclark commented Dec 19, 2022

@mabrand any possibility of this being merged? I'm planning to be away for the next few weeks and want to be around if there are questions or concerns.

@hdclark
Copy link
Author

hdclark commented Jan 18, 2023

Bump. Anyone available to comment on this?

@hdclark
Copy link
Author

hdclark commented Jun 12, 2023

Bump. Updated to version 0.18.1.

@hdclark hdclark changed the title Add Apache Thrift 0.17.0 runtime libraries. Add Apache Thrift 0.18.1 runtime libraries. Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant