This bakes in the msw theme into gtk2 #2534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump |
|
bump |
|
just doing one more bump |
mabrand
reviewed
Sep 10, 2020
| +#define MODULE_ENTRY(type, function) type _gtk_theme_wimp_ ## function | ||
| +#else | ||
| +#define MODULE_ENTRY(type, function) G_MODULE_EXPORT type theme_ ## function | ||
| +#endif |
There was a problem hiding this comment.
Are you sure G_MODULE_EXPORT isn't needed for G_OS_WIN32? Have you tested static and shared builds?
There was a problem hiding this comment.
This was mostly based on an old patch that I migrated to a newer gtk, however as for 64bit shared builds, gtk2 never built for me in shared form period so even before this patch it still didn't exactly compile period in that form on any of my rigs. My test case showed it does work, but I have not extensively tested it outside of static builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revised PR with proper patch support that allows the msw theme be baked into gtk2 itself