Tried to build on Windows and start working with it #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I used the now-standard data-raw directory for the datasets. - I used the file.path(..) function for platform independent paths (for Windows compatiblity) At least on my windows machine, the SAS and
The SAS and STATA files do not download well on Windows machines.
…p.sas7bdat", file.path("..", "data-raw", "datasets", "data.sas7bdat"), method = 'curl') } # method = 'curl' works on Windows machines. You can set this to 'auto' # or other on different systems if you get invalid files. ```
… the origianal SPPS file only 0.98 sec versus the original 4.183998 secs The rationale is that the original had a lot of problems with large Eurobarometer files.
|
Apart from the small changes to make the package work on Windows, I created a vectorized version of the create_metadata function. It is running 5 times faster, which is important because the original program has a hard time with GESIS Eurobarometer / EVS surveys. |
|
Great! Will look at this tomorrow!! |
|
I started putting my take on Github, too.
http://eurobarometer.danielantal.eu/articles/metadata.html
…On Wed, May 13, 2020 at 8:50 PM Markus Kainu ***@***.***> wrote:
Great! Will look at this tomorrow!!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2G6MC64WI7UEKLSV7SFULRRLTWBANCNFSM4M7YNEPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made several small changes to make the vignette platform independent and confirm more to current documentation standards. This is related to the use of file.path(), which creates platform independent path names (and requried by CRAN) and a more explicit configuration of the download.file() function, I used method = 'curl', because the 'auto' method resulted in character coding issues of the STATA and SAS files.
However, the last two chunks do not run at all, and that may be related to either some problem in the code or recent changes in the labelled dependency.