This repository uses github actions to build ROS2 rolling from source ,plus other relevant packages, and performs static analysis using sonarcloud tools
.Its aim is to improve stability and code quality of ROS2 packages by mean of static code analysis.
Extracted bugs, vulnerabilities and code smells are listed below in this document, grouped by package.
Each entry is formed by a file:line and message, with a link to the specific sonacloud link.
This page is generated automatically after every static analysys.
The complete results of the analysis can be found here .
Github truncates this file, i am currently looking for a solution but in the meantime the complete file can be downloaded and rendered locally
ros2
- file : ros2/ros2cli/ros2cli/test/test_ros2cli_daemon.py:77
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/ros2cli/ros2cli/test/test_ros2cli_daemon.py:82
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/ros2cli/ros2cli/test/test_ros2cli_daemon.py:94
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/ros2cli/ros2cli/test/test_ros2cli_daemon.py:100
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/ros2cli/ros2cli/test/test_ros2cli_direct.py:48
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/ros2cli/ros2doctor/ros2doctor/api/network.py:54
message : Return a value of typestr
in this method.
LINK
- file : ros2/rosbag2/rosbag2_py/test/test_sequential_reader.py:137
message : The return value of "isinstance" must be used.
LINK
- file : ros2/rosbag2/rosbag2_py/test/test_sequential_reader.py:148
message : The return value of "isinstance" must be used.
LINK
- file : ros2/rosbag2/rosbag2_py/test/test_sequential_reader.py:159
message : The return value of "isinstance" must be used.
LINK
- file : ros2/rosbag2/rosbag2_py/test/test_sequential_reader.py:166
message : The return value of "isinstance" must be used.
LINK
- file : ros2/rosbag2/rosbag2_py/test/test_sequential_writer.py:36
message : Remove or correct this useless self-assignment.
LINK
- file : ros2/rosidl/rosidl_adapter/test/test_base_type.py:85
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/rosidl/rosidl_adapter/test/test_parse_primitive_value_string.py:212
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl/rosidl_adapter/test/test_type.py:79
message : Remove or refactor this statement; it has no side effects.
LINK
- file : ros2/rosidl/rosidl_parser/test/test_parser.py:115
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl/rosidl_parser/test/test_parser.py:398
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:66
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:67
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:85
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:87
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:275
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:276
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:297
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_python/rosidl_generator_py/test/test_interfaces.py:298
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_convert.py:53
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_convert.py:54
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_convert.py:55
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_convert.py:56
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_set_message.py:184
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_set_message.py:187
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_set_message.py:200
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_set_message.py:203
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_runtime_py/test/rosidl_runtime_py/test_set_message.py:206
message : Do not perform equality checks with floating point values.
LINK
- file : ros2/rosidl_typesupport/rosidl_typesupport_c/test/mocking_utils/patch.hpp:343
message : "std::forward" should only be called on a forwarding reference.
LINK
- file : ros2/rviz/rviz_common/help/help.html:8
message : Insert a !DOCTYPE declaration to before this html tag.
LINK
- file : ros2/rviz/rviz_common/help/help.html:8
message : Add "lang" and/or "xml:lang" attributes to this "html" element
LINK
- file : ros2/rviz/rviz_common/help/help.html:9
message : Add a title tag to this page.
LINK
- file : ros2/rviz/rviz_common/help/help.html:24
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:63
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:76
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:86
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:104
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:129
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:159
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:184
message : Add "th" headers to this "table".
LINK
- file : ros2/rviz/rviz_common/help/help.html:209
message : Add "th" headers to this "table".
LINK
ISSUES are filtered and only blocking and critical issues are reported due to the high quantity of issues
The complete list of issues can be found here .