Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15726 (Voltas): Some elements are lost when changing time signature #27340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pacebes
Copy link
Contributor

@pacebes pacebes commented Mar 24, 2025

Resolves: #15726 (Voltas)

This PR:

  • Avoid restoring Voltas that doesn't fit with new measure size after changing time signature
  • Changes Voltas length to adapt to new measure size when necessary
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@pacebes
Copy link
Contributor Author

pacebes commented Mar 24, 2025

I attach a Score just it case it helps to test this PR: Score_15726_Voltas_test1.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some elements are lost when changing time signature
1 participant