Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EditStyle > Lyrics a bit #27255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbjeukendrup
Copy link
Contributor

Resolves text clipping mentioned at #13773 (comment)
Removes unnecessary nesting of layouts

@cbjeukendrup cbjeukendrup force-pushed the editstyle_lyrics_refactor branch from 3c541ea to b446dfb Compare March 20, 2025 16:37
@FrancRos31
Copy link

@cbjeukendrup thx for the PR.

1
At a second glance I noticed that I can solve this clipping issue by changing the translation. I didn't notice it before because I hadn't checked the translation before adding the above image in #13773.

Slur (string 4464) is not the best term to indicate a not-straight line, imo.
2
I'll ask to change the string in a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants