-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Keysigs on section break #25260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Keysigs on section break #25260
Conversation
c7ec3da
to
02df82c
Compare
02df82c
to
55a7767
Compare
Im just thinking, if this is not somehow overcomplicated. May be simply adding key sig (and clef and timesig) always, when adding section break. End when removing section break, we could leve them there. |
A section break basically starts a new piece, so should start like the very 1st measure of a score, Clef, time- and key signature, as per the staff settings (which can disable them), but without courtesies. |
If those would be marked as 'generated', they'd vanish on section break removal I'd guess? I think, mark them as "generated" is semantically incorrect. |
3058c42
to
1bc91e8
Compare
Doesnt work in parts. |
3021408
to
e4436ad
Compare
(added "forSectionBreak" to keysigs)
92f23ab
to
64251f4
Compare
@mike-spa it should be done I needed to make some changes, sorry, please check, if it could be this way. Now, it always acts in masterscore, to be sure, key signatures are added / removed into / from all staves. |
Resolves: #25168