Skip to content

Resolved Braille Input mode accessibility #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shubham-shinde-442
Copy link
Contributor

Resolves: #20554

Renamed Braille TextArea to include Modes.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup cbjeukendrup requested a review from shoogle July 19, 2024 02:05
Copy link
Contributor

@shoogle shoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are welcome, but they don't fix the problem at hand, at least not on Windows with NVDA or Narrator.

When tabbing to the braille panel, it correctly says "Normal mode" or "Note input mode".

However, when you're already in the braille panel and you press N, it doesn't say anything. That's what this issue is about.

FYI, PR #13383 fixed a similar issue but in the score rather than the braille panel. You probably need a similar solution here, i.e. notify the accessibility system that item's name has changed, but you'd have to do it in a way that works with general accessible items, not just score elements.

@shoogle
Copy link
Contributor

shoogle commented Aug 11, 2024

@shubham-shinde-442, I managed to get the screen reader to announce the name change. See my code.

I had to stop the score going into note input mode, but that's not acceptable so you'll need to find out why putting the score in note input mode masks the name change in the braille panel.

Ideally we wouldn't have to create a fake sibling just to get speech to work, but it's an acceptable hack if no other solution is readily available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input not announced in braille panel
3 participants