Highlight notes under playback cursor #22398
Draft
+85
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #11313
Re-adds the MuseScore 3 feature where notes under the playback cursor are highlighted during playback.
This PR is a draft because the implementation is extremely hacky. I don’t think
PlaybackCursor
is the right place to implement this. MuseScore 3 implements this feature inSeq::heartbeatTimeout
, but as the playback engine in MS4 is completely different, I have no idea where this is best implemented.Also, arpeggios and grace notes are not highlighted properly.