Skip to content

Highlight notes under playback cursor #22398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bluebear94
Copy link
Contributor

@bluebear94 bluebear94 commented Apr 15, 2024

Resolves: #11313

Re-adds the MuseScore 3 feature where notes under the playback cursor are highlighted during playback.

This PR is a draft because the implementation is extremely hacky. I don’t think PlaybackCursor is the right place to implement this. MuseScore 3 implements this feature in Seq::heartbeatTimeout, but as the playback engine in MS4 is completely different, I have no idea where this is best implemented.

Also, arpeggios and grace notes are not highlighted properly.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight voice colours during playback
1 participant