Skip to content

New Courtesy Accidentals plugin #21352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoMigros
Copy link
Contributor

The current courtesy accidentals plugin is limited in where it adds courtesy accidentals, and the UI for configuring the settings isn't particularly good-looking. In an attempt to tackle both of those issues, here's a new Courtesy Accidentals plugin.

image

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros force-pushed the courtesy-accidentals branch from 29fcf51 to 3a39c3a Compare February 3, 2024 19:54
@igorkorsukov igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08
@XiaoMigros XiaoMigros force-pushed the courtesy-accidentals branch 2 times, most recently from 13a814e to 0b951fa Compare February 21, 2024 11:12
@RomanPudashkin RomanPudashkin requested a review from Eism April 19, 2024 06:53
@XiaoMigros XiaoMigros force-pushed the courtesy-accidentals branch from 0b951fa to 85ffca3 Compare April 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants