Skip to content

Move input cursor past tied chords #21077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoMigros
Copy link
Contributor

Currently, the input cursor does not take into account tied notes when calculating the new position:
image

Now, the cursor places itself at the end of a tied chord:
image

Worth mentioning that not all input methods calculate the new cursor position via the method changed in this PR, perhaps it's worth standardising this behavior?

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@its-not-nice its-not-nice requested a review from bkunda January 19, 2024 13:05
@igorkorsukov igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08
@bkunda
Copy link

bkunda commented Apr 18, 2024

@XiaoMigros sorry for not checking this earlier.
Can you please rebase and I'll test it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants