Skip to content

Recommend unique filename for new/default score #21029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

channingko-madden
Copy link

Resolves: #20140

In the special case of a newly created score that has a default title, and there already exists an "Untitled\ score.mscz" file in the chosen save directory, recommend a different file name when saving locally (ex. "Untitled\ score (1).mscz") to prevent accidental overwriting.

This issue was brought up by a user who accidentally saved over an existing file, even though there is usually an overwrite dialog warning raised by the OS in this scenario, but thought MuseScore would number the new file in an intelligent way.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

In the special case of a newly created score that has a default
title, and there already exists an "Untitled\ score.mscz" file
in the chosen save directory, recommend a different file name
when saving (ex. "Untitled\ score (1).mscz") to prevent
accidental overwriting.

Inspired by when you download a file with the same name from the
web, it saves a separate copy instead of overwriting the existing
file.

Issue: musescore#20140
@igorkorsukov igorkorsukov force-pushed the master branch 6 times, most recently from fa1f8d3 to 525a11a Compare February 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant