Fix crashing of tuning plugins by Bill Hails

[jacobdill75]

Resolves: #19326

When developing my own tuning plugin for MS4 on MacOS, I noticed that since 4.1, Qt Text components would crash only on Mac (fine on windows 10+). I then noticed that the vanilla tuning plugins by Bill Hails also crashes for the same reason.

While I made the "simplest" changes to fix this crash (updating Qt.Controls version in the plugin implementations), one downside of this fix is the loss of theming that was inherited by earlier Qt.Controls packages (somehow). Consider the before and after:

This may raise accessibility concerns, in addition to the fact that these changes will be made to both Windows and Mac, despite the crash only occurring on Mac. My preferred patch (if I could budget the time) would be either (i) to deploy the patched version only for Mac, or (ii) to rewrite the plugin using MuseScore.UIComponents as mentioned here.

Nonetheless, I hope that this PR can at least inspire the changes that fixes these plugins for MacOS, as they have served me well for microtonal compositions.

• I signed the CLA
• The title of the PR describes the problem it addresses
• Each commit's message describes its purpose and effects, and references the issue it resolves
• If changes are extensive, there is a sequence of easily reviewable commits
• The code in the PR follows the coding rules
• There are no unnecessary changes
• The code compiles and runs on my machine, preferably after each commit individually
• I created a unit test or vtest to verify the changes I made (if applicable)

[wizofe]

Why hasn't this merged yet? I am working on microtonal compositions, and it's a real shame that MuseScore keeps crashing because of this issue. I am unable to use the software at the moment. Is there any way I could help?

[Eism]

@jacobdill75
Your solution looks good! Please rebase to the current master and we will merge it

[wizofe]

Hm, I actually just checked your latest nightly-master and it seems to be working. Maybe this isn't needed anymore? Needs investigation.

[jacobdill75]

Hm, I actually just checked your latest nightly-master and it seems to be working. Maybe this isn't needed anymore? Needs investigation.

From what I can see, the Qt versions have been updated in master already, and I suspected that my fix is not needed. (e40b589 and 7fe32ba)

On an upgraded 4.3.1 installation for Mac, the plugin still crashed, however.