Fix resume download by not using cache date. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use cache date if trying to resume download: if the "If-Modified-Since:" HTTP header is present, Apple servers ignores the Range: HTTP header.
|
So actually, my patch fails when the file is complete (needed to download the big dmg file to see that), the server might send a 416 range not satisfiable. I would just ignore curl error in this case maybe, the script would work. Getting detailed error with the python/curl subprocess is quite cumbersome... |
|
I think this is obsoleted by #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use cache date if trying to resume download: if
the "If-Modified-Since:" HTTP header is present, Apple
servers ignores the Range: HTTP header.