Cpp17 trial #6175
Draft
Cpp17 trial #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure :) |
|
The access to the logs is public, so I can see them as well so you did not need to post them, but thanks anyway ;) |
|
Well too bad the build environment is cached, and therefore cannot use my ice fork vcpkg port changes, any easy way to workaround that? |
Not really. The CI can't build all dependencies on-the-fly so we have to use a pre-built env.
Personally, I always wanted to separate the Overlay out into a separate plugin or something like that (in a standalone repo). |
|
alright, it did build now with my manipulated build environment(I downloaded the old one and copied new ice files over that, but it got a whole 1GB bigger, don't exactly know what I did wrong^^) Any idea how these build environments are created in a clean way? I'm now gonna open a PR for our ice fork, which basically just made it up to date to the original repository. Can't really test it on windows because the master branch is already broken: |
They are built via vcpkg and then bundled using Sorry for the late response. I kind ignored this PR assuming that you were just playing around with different compile options 🙈 |
|
Well in the meantime I experimented using VCPKG binary cache which works fine as well, and would be perhaps be a preferred approach, because it is gonna be easier to update targeted packages. Edit:
Well it still is just experimental, that's why it is a draft, so no worries there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to try to get it to cpp 17, but have no working windows environment, and azure still did not give me any building time.
So I'll try to use your azure build, I hope that is ok