Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue report form #353

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 20, 2024

Description

Added the issue report form. I would like to know if there are any improvements needed.

Related Issue

Fixes #350

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 933e3c8
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/674222b45cc22a0008adf712
😎 Deploy Preview https://deploy-preview-353--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@multiverseweb
Copy link
Owner

Hi @amin-xiv, the form works fine on desktop, but there some issues with font-size and alignment in mobile-view. Here's the screenshot:
image

Tip

I was thinking if we can shift the form to a new page and link in the navbar. This will help us add more related links and information later to that page. Like Support and FAQs section.

Let me know if you need any help doing this.
Thanks! 😊

@amin-xiv
Copy link
Contributor Author

Hi @amin-xiv, the form works fine on desktop, but there some issues with font-size and alignment in mobile-view. Here's the screenshot: image

Tip

I was thinking if we can shift the form to a new page and link in the navbar. This will help us add more related links and information later to that page. Like Support and FAQs section.

Let me know if you need any help doing this. Thanks! 😊

Hi @multiverseweb , I will try to fix the issues when in mobile view, and I will be making a new page, maybe call it support. I have a suggestion, since the sidebar contains a link to the main page, but we are already in the main page, we can replace it with the link to the support page instead. What do you think about this? Thank you.

@amin-xiv
Copy link
Contributor Author

Hi @multiverseweb , I have a question, what is L, since I am getting lots of console errors saying that L is not defined.
Here is where it is first used:
var map = L.map('map', {....}
Thank you.

@multiverseweb
Copy link
Owner

Hi @amin-xiv, the form works fine on desktop, but there some issues with font-size and alignment in mobile-view. Here's the screenshot: image

Tip

I was thinking if we can shift the form to a new page and link in the navbar. This will help us add more related links and information later to that page. Like Support and FAQs section.

Let me know if you need any help doing this. Thanks! 😊

Hi @multiverseweb , I will try to fix the issues when in mobile view, and I will be making a new page, maybe call it support. I have a suggestion, since the sidebar contains a link to the main page, but we are already in the main page, we can replace it with the link to the support page instead. What do you think about this? Thank you.

Yes @amin-xiv, we can replace it with support.

@multiverseweb
Copy link
Owner

Hi @multiverseweb , I have a question, what is L, since I am getting lots of console errors saying that L is not defined.
Here is where it is first used:
var map = L.map('map', {....}
Thank you.

@amin-xiv L is the global namespace for Leaflet, a popular open-source JavaScript library for interactive maps.
I have included these two lines in the index.html file and according to chatGPT, these console errors should not occur if these lines have been included.

<link rel="stylesheet" href="https://unpkg.com/leaflet/dist/leaflet.css" />
<script src="https://unpkg.com/leaflet/dist/leaflet.js"></script>

I'll look into it tonight, thanks for pointing it out!

@amin-xiv
Copy link
Contributor Author

@multiverseweb Thanks for the clarification.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 23, 2024

Hi @multiverseweb ,
I have created the support.html page, along some empty cards and sections for future features such as FAQs section. Also, I removed the link in the sidebar to the home page and replaced it with the support page.

Since I had to link the script.js file, there were LOTS of console errors about elements missing from the support page due to the functionality in the script.js file, I had to add some checks (which will work perfectly fine in the main page) that checks the availability of the elements that are being used to avoid unneeded error messages in the other pages that use script.js file, and their have been some other minor adjustments to make it is smooth as possible. I have done all of this while making sure the main page is not affected ever.

Thank you.

@multiverseweb multiverseweb self-requested a review November 23, 2024 21:35
@multiverseweb multiverseweb merged commit e8b56f4 into multiverseweb:main Nov 23, 2024
5 checks passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #353 has been merged! 🎉🎉

@amin-xiv amin-xiv deleted the bug-report-form branch November 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Add 'Report a bug' form
2 participants