Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have changed login to profile and error messeges too #285

Closed
wants to merge 3 commits into from

Conversation

vibhamishra09
Copy link

@vibhamishra09 vibhamishra09 commented Nov 4, 2024

have changed login to profile button after login and error boxes shows while not following email and password guidelines

have changed login button to profile button after successful login and error boxes arrives when not following email and password guidlines

Fixes #276

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 99a08a2
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672e5c6d15ec330008d80833
😎 Deploy Preview https://deploy-preview-285--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Contributor

jency1 commented Nov 5, 2024

@vibhamishra09 If you can show some video, then it would be better. Because I am not able to see profile image after logging in. Also, resolve all conflicts.

@vibhamishra09
Copy link
Author

have made some changes

compressed_video.mp4

@jency1
Copy link
Contributor

jency1 commented Nov 7, 2024

@vibhamishra09 Resolve conflicts.

@multiverseweb
Copy link
Owner

multiverseweb commented Nov 9, 2024

Hey @vibhamishra09, it work great! But here are some changes I would suggest:

  • fix the path of images and style files in login.html

Current
image

Expected
image

  • Change the content of profile button to the profile image. You can use this image, it is already in the repo: website/web_images/user.png

image

  • Change the contents of this page to Currently under development.

image

Thanks for the wonderful contribution, hope you can make the changes soon.
Also, create a new PR when the changes are done as this one has several merge conflicts.

@multiverseweb
Copy link
Owner

@vibhamishra09 reminder to make the stated changes, its the last chance to make your contribution count for GSSoC!
Good luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after successful login the login button changes to profile icon
3 participants