Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signing and notarization to loader #7717

Open
wants to merge 7 commits into
base: installer-downloader
Choose a base branch
from

Conversation

dlon
Copy link
Member

@dlon dlon commented Feb 24, 2025


This change is Reviewable

@dlon dlon requested a review from raksooo February 24, 2025 20:43
@dlon dlon force-pushed the installer-downloader-sign branch 4 times, most recently from e66a7de to 20daedf Compare February 25, 2025 09:38
@dlon dlon requested review from hulthe and removed request for raksooo February 25, 2025 15:16
@dlon dlon force-pushed the installer-downloader-sign branch from 20daedf to 22cd6c7 Compare February 25, 2025 15:33
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


installer-downloader/build.sh line 27 at r1 (raw file):

source ../scripts/utils/log

CARGO_TARGET_DIR=${CARGO_TARGET_DIR:-"../target"}

Should this be exported so that cargo uses it? In practice it might won't matter, since ../target is the folder cargo would have used anyway because of the workspace manifest, but it still feels like this should be exported.

Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved


installer-downloader/build.sh line 27 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Should this be exported so that cargo uses it? In practice it might won't matter, since ../target is the folder cargo would have used anyway because of the workspace manifest, but it still feels like this should be exported.

Done.

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


installer-downloader/build.sh line 29 at r1 (raw file):

CARGO_TARGET_DIR=${CARGO_TARGET_DIR:-"../target"}
BUILD_DIR="./build"
DIST_DIR="./dist"

what's the difference between these? could you add comments? :]

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

@dlon dlon force-pushed the installer-downloader-sign branch 2 times, most recently from c5cac2d to 51d3b12 Compare February 25, 2025 20:01
@dlon dlon force-pushed the installer-downloader branch from ea2bf5d to db28ddb Compare February 27, 2025 08:17
@dlon dlon force-pushed the installer-downloader-sign branch from 51d3b12 to 4aa2da3 Compare February 27, 2025 08:18
@dlon dlon force-pushed the installer-downloader branch from db28ddb to 165d53d Compare February 27, 2025 08:21
@dlon dlon force-pushed the installer-downloader-sign branch 2 times, most recently from 3955f30 to 5aff396 Compare February 27, 2025 15:04
@dlon dlon force-pushed the installer-downloader-sign branch from 5aff396 to 9d92421 Compare February 27, 2025 16:23
@dlon dlon force-pushed the installer-downloader-sign branch from 9d92421 to 1d79d55 Compare February 27, 2025 16:24
/usr/bin/security set-keychain-settings "$SIGN_KEYCHAIN_PATH"

# Add our keychain to the search list, keeping existing keychains, or codesign won't find it
/usr/bin/security list-keychains -d user -s "$SIGN_KEYCHAIN_PATH" "$(security list-keychains -d user | tr -d '"')"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Use absolute path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants