-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add signing and notarization to loader #7717
base: installer-downloader
Are you sure you want to change the base?
Conversation
e66a7de
to
20daedf
Compare
20daedf
to
22cd6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
installer-downloader/build.sh
line 27 at r1 (raw file):
source ../scripts/utils/log CARGO_TARGET_DIR=${CARGO_TARGET_DIR:-"../target"}
Should this be exported so that cargo
uses it? In practice it might won't matter, since ../target
is the folder cargo would have used anyway because of the workspace manifest, but it still feels like this should be exported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
installer-downloader/build.sh
line 27 at r1 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Should this be exported so that
cargo
uses it? In practice it might won't matter, since../target
is the folder cargo would have used anyway because of the workspace manifest, but it still feels like this should be exported.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
installer-downloader/build.sh
line 29 at r1 (raw file):
CARGO_TARGET_DIR=${CARGO_TARGET_DIR:-"../target"} BUILD_DIR="./build" DIST_DIR="./dist"
what's the difference between these? could you add comments? :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
c5cac2d
to
51d3b12
Compare
ea2bf5d
to
db28ddb
Compare
51d3b12
to
4aa2da3
Compare
db28ddb
to
165d53d
Compare
3955f30
to
5aff396
Compare
5aff396
to
9d92421
Compare
9d92421
to
1d79d55
Compare
/usr/bin/security set-keychain-settings "$SIGN_KEYCHAIN_PATH" | ||
|
||
# Add our keychain to the search list, keeping existing keychains, or codesign won't find it | ||
/usr/bin/security list-keychains -d user -s "$SIGN_KEYCHAIN_PATH" "$(security list-keychains -d user | tr -d '"')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Use absolute path.
This change is