Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Wireguard obfuscation info text #7704

Merged

Conversation

tobias-jarvelov
Copy link
Contributor

@tobias-jarvelov tobias-jarvelov commented Feb 21, 2025

Fixes typo in Wireguard obfuscation info text. Note that the typo is still present in the android app and as such the old translation is still present in the messages.pot file.


This change is Reviewable

Copy link

linear bot commented Feb 21, 2025

@@ -247,7 +247,7 @@ function ObfuscationSettings() {
<ModalMessage>
{messages.pgettext(
'wireguard-settings-view',
'Obfuscation hides the WireGuard traffic inside another protocol. It can be used to help circumvent censorship and other types of filtering, where a plain WireGuard connect would be blocked.',
'Obfuscation hides the WireGuard traffic inside another protocol. It can be used to help circumvent censorship and other types of filtering, where a plain WireGuard connection would be blocked.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a TRANSLATORS comment here as well t provide context to the translators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've added a TRANSLATORS comment now. Hopefully with a helpful text.

@tobias-jarvelov tobias-jarvelov force-pushed the wireguard-obfuscation-info-text-typo-des-1370 branch 3 times, most recently from 68eeb30 to b2121c2 Compare February 21, 2025 13:27
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)

@MarkusPettersson98 MarkusPettersson98 force-pushed the wireguard-obfuscation-info-text-typo-des-1370 branch from b2121c2 to ab49083 Compare February 28, 2025 09:50
@MarkusPettersson98 MarkusPettersson98 merged commit 4c3c052 into main Feb 28, 2025
11 of 12 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the wireguard-obfuscation-info-text-typo-des-1370 branch February 28, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants