Fix bug where block_on was called from an async context
#7425
Conversation
There was a problem hiding this comment.
Great work finding and fixing this! log_tunnel_data_usage is called on line 493 too, for the android version of the function. You should probably make the same change there also
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
NVM, I didn't realize that the bug only affects Linux
Reviewable status:
There was a problem hiding this comment.
You are right though, we should assume that the log_tunnel_data_usage performs blocking IO imho. Atleast it is not async anymore 😊
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @Serock3)
There was a problem hiding this comment.
This PR literally changed my life.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
MarkusPettersson98
force-pushed
the
patch-block-on-in-tokio-task
branch
from
a2c5b58 to
beee5dc
Compare
MarkusPettersson98
changed the base branch from
prepare-2024.9
to
prepare-2025.2
This PR fixes a regression introduced in the 2025.1 release. The fix is simple enough, simply call
log_tunnel_data_usagefrom a thread where blocking is acceptable.This change is