Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more clear with connection state #7401

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 23, 2024

This PR correctly shows the tunnel state in some fast transient states. E.g when disconnecting, we previously showed disconnected but the state has not fully reached disconnected yet. Same goes for blocking, (going from Connected to Blocked state), the UI would still show Connected while in fact we are migrating to another state.

This has no security implication just being more accurate and transparent with what actual state that is happening.


This change is Reviewable

Copy link

linear bot commented Dec 23, 2024

@Rawa Rawa self-assigned this Dec 23, 2024
@Rawa Rawa added the Android Issues related to Android label Dec 23, 2024
Pururun
Pururun previously approved these changes Jan 7, 2025
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me, but should perhaps be aligned with design and desktop?

Reviewed 27 of 28 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch 2 times, most recently from 83dab41 to 23b6566 Compare January 7, 2025 09:59
@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch from 23b6566 to ac2b2ec Compare January 7, 2025 10:02
Pururun
Pururun previously approved these changes Jan 7, 2025
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconnecting while far away from disconnected location sometimes causes long in and out zoom. Should probably cancel the animation instead.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch from ac2b2ec to bb02ce4 Compare January 7, 2025 13:07
@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch from bb02ce4 to c0238db Compare January 7, 2025 13:41
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now :)

Reviewable status: 29 of 30 files reviewed, all discussions resolved (waiting on @Pururun)

@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch 6 times, most recently from cc363c3 to dad46e9 Compare January 7, 2025 15:29
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

Reviewed 26 of 26 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/util/FlowUtils.kt line 66 at r5 (raw file):

    }

fun <T> Flow<T>.withPrev(): Flow<Pair<T, T?>> = flow {

🚀

@Rawa Rawa force-pushed the be-honest-with-connection-state-droid-1690 branch from dad46e9 to 770cf2c Compare January 7, 2025 15:46
@Rawa Rawa merged commit cd277a1 into main Jan 7, 2025
30 of 31 checks passed
@Rawa Rawa deleted the be-honest-with-connection-state-droid-1690 branch January 7, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants