-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more clear with connection state #7401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from me, but should perhaps be aligned with design and desktop?
Reviewed 27 of 28 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
83dab41
to
23b6566
Compare
23b6566
to
ac2b2ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 19 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reconnecting while far away from disconnected location sometimes causes long in and out zoom. Should probably cancel the animation instead.
Reviewable status: complete! all files reviewed, all discussions resolved
ac2b2ec
to
bb02ce4
Compare
bb02ce4
to
c0238db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now :)
Reviewable status: 29 of 30 files reviewed, all discussions resolved (waiting on @Pururun)
cc363c3
to
dad46e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 26 of 26 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/util/FlowUtils.kt
line 66 at r5 (raw file):
} fun <T> Flow<T>.withPrev(): Flow<Pair<T, T?>> = flow {
🚀
dad46e9
to
770cf2c
Compare
This PR correctly shows the tunnel state in some fast transient states. E.g when disconnecting, we previously showed disconnected but the state has not fully reached disconnected yet. Same goes for blocking, (going from Connected to Blocked state), the UI would still show Connected while in fact we are migrating to another state.
This has no security implication just being more accurate and transparent with what actual state that is happening.
This change is