[notifications] Fix: #4959 transition on close #4960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `close` now sets the notification's `open` prop to `false` before removing it from the queue.
Netlify deploy preview |
|
Thanks for contributing! Works, tested with https://codesandbox.io/p/devbox/nervous-fire-tyyrhm?workspaceId=ws_8roDQkQB8Gsa4Et8HYWgP6 @Janpot impacts the |
bharatkashyap
approved these changes
May 19, 2025
|
@Janpot I'm happy to refactor this if you have feedback btw! |
|
Instead of a timeout, I wonder if this can use onExited of the transition instead? |
|
That sounds much cleaner, thank you - I'll give it a go |
…d to remove Notifications from Queue
…ications queue - Also refactored `remove` to be consistent with the other context methods. Possible this version is easier for React to optimise?
dchae
commented
May 23, 2025
| @@ -90,10 +93,25 @@ function Notification({ notificationKey, open, message, options, badge }: Notifi | |||
|
|
|||
| const props = React.useContext(RootPropsContext); | |||
| const SnackbarComponent = props?.slots?.snackbar ?? Snackbar; | |||
|
|
|||
| // Passing `onExited` through `externalSlotProps` here. | |||
There was a problem hiding this comment.
@Janpot This is not ideal, but I couldn't think of a better way that didn't involve rewriting mergeSlotProps. Let me know if I'm missing something - I'm fairly new to React and mui.
|
is this going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4959