Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Backdrop] Deprecate components and componentProps props for v7 #42026

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

aacevski
Copy link
Contributor

@aacevski aacevski commented Apr 25, 2024

Issue: #41279

@DiegoAndai do I need to change something else?

@mui-bot
Copy link

mui-bot commented Apr 25, 2024

Netlify deploy preview

https://deploy-preview-42026--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6d0b35b

@zannager zannager added the component: backdrop This is the name of the generic UI component, not the React module! label Apr 26, 2024
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aacevski, thanks for working on this!

Component-wise, this is the only thing we need to do, besides running pnpm proptypes to update the proptypes adding the deprecation warnings.

But we also need to add a codemod in this PR, you can follow this as a guide: f59094e

@@ -1,26 +1,26 @@
import Backdrop from '@mui/material/Backdrop';
import { Backdrop as MyBackdrop } from '@mui/material';

<Backdrop TransitionComponent={CustomTransition} />;
<MyBackdrop TransitionComponent={CustomTransition} />;
<Backdrop slots={{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case shouldn't be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: backdrop This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants