Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Update the installation commands to use @next #41966

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

[material-ui][docs] Update the installation commands to use @next #41966

wants to merge 3 commits into from

Conversation

wapgear
Copy link

@wapgear wapgear commented Apr 19, 2024 •
edited by danilo-leal

Use @next branch for @mui/icons-material package and for @mui/material with styled-components as well

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree

npm ERR! Found: @mui/[email protected]
npm ERR! node_modules/@mui/material
npm ERR!   @mui/material@"^6.0.0-alpha.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @mui/material@"^5.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/icons-material
npm ERR!   @mui/icons-material@"*" from the root project

@wapgear
Update installation.md
90eba41 
Use `@next` branch for `@mui/icons-material` pacakge and for `@mui/material` with styled-components too

```
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree

npm ERR! Found: @mui/[email protected]
npm ERR! node_modules/@mui/material
npm ERR!   @mui/material@"^6.0.0-alpha.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @mui/material@"^5.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/icons-material
npm ERR!   @mui/icons-material@"*" from the root project
```

Signed-off-by: Anton Izmailov <[email protected]>
@danilo-leal danilo-leal changed the title Update installation.md [material-ui][docs] Update the installation commands to use @next Apr 19, 2024
@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Apr 19, 2024
danilo-leal
danilo-leal approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Thanks for your first contribution! 🤝

@wapgear
Copy link
Author

wapgear commented Apr 26, 2024 •
edited

Seems fine to me! Thanks for your first contribution! 🤝

Hey @danilo-leal. What should be my next steps to get it merged? Did I miss something?

@danilo-leal danilo-leal enabled auto-merge (squash) May 1, 2024 10:08
@danilo-leal danilo-leal closed this May 1, 2024
auto-merge was automatically disabled May 1, 2024 12:49

Pull request was closed

@danilo-leal danilo-leal reopened this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wapgear @danilo-leal