Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Add docs for complementary stepper components #41900

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

anle9650
Copy link
Contributor

@anle9650 anle9650 commented Apr 14, 2024

Part of #39952. Fixes #41454.

@zannager zannager added docs Improvements or additions to the documentation component: stepper This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 15, 2024
@DiegoAndai
Copy link
Member

@michaldudak, would you know the reason for this failure?

@michaldudak
Copy link
Member

No idea. It seems that only this PR is affected. We could try recreating the PR.

@anle9650
Copy link
Contributor Author

We could try recreating the PR.

I tried creating a new branch from upstream/next in #41993, but ran into the same problem 🤔

@michaldudak
Copy link
Member

Since this PR touches just the docs, it's safe to bypass the checks and merge it.

@DiegoAndai
Copy link
Member

Hey @anle9650, thanks for working on this. The changes look good to me, but I want to wait for @samuelsycamore's review in case there's anything to add or rephrase.

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small style tweaks here, otherwise looking good. Thanks @anle9650 !

@@ -22,6 +22,28 @@ Steppers may display a transient feedback message after a step is saved.
This component is no longer documented in the [Material Design guidelines](https://m2.material.io/), but Material UI will continue to support it.
:::

## Introduction

Stepper displays progress through a sequence of logical and numbered steps. It support horizontal and vertical orientation for desktop and mobile viewports.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Stepper displays progress through a sequence of logical and numbered steps. It support horizontal and vertical orientation for desktop and mobile viewports.
The Stepper component displays progress through a sequence of logical and numbered steps.
It supports horizontal and vertical orientation for desktop and mobile viewports.


Stepper displays progress through a sequence of logical and numbered steps. It support horizontal and vertical orientation for desktop and mobile viewports.

Material UI Steppers are implemented using a collection of related components:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Material UI Steppers are implemented using a collection of related components:
Steppers are implemented using a collection of related components:


Material UI Steppers are implemented using a collection of related components:

- Stepper: a required container for steps. Renders as a `<ol>` by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Stepper: a required container for steps. Renders as a `<ol>` by default.
- Stepper: the container for the steps. Renders as a `<ol>` by default.

Material UI Steppers are implemented using a collection of related components:

- Stepper: a required container for steps. Renders as a `<ol>` by default.
- Step: a step. Renders as a `<li>` by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step: a step. Renders as a `<li>` by default.
- Step: an individual step in the sequence. Renders as a `<li>` by default.


- Stepper: a required container for steps. Renders as a `<ol>` by default.
- Step: a step. Renders as a `<li>` by default.
- Step Label: a label of a step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step Label: a label of a step.
- Step Label: a label for a Step.

- Stepper: a required container for steps. Renders as a `<ol>` by default.
- Step: a step. Renders as a `<li>` by default.
- Step Label: a label of a step.
- Step Content: an optional content of a step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step Content: an optional content of a step.
- Step Content: optional content for a Step.

- Step: a step. Renders as a `<li>` by default.
- Step Label: a label of a step.
- Step Content: an optional content of a step.
- Step Button: an optional button of a step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step Button: an optional button of a step.
- Step Button: optional button for a Step.

- Step Label: a label of a step.
- Step Content: an optional content of a step.
- Step Button: an optional button of a step.
- Step Icon: an optional icon of a step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step Icon: an optional icon of a step.
- Step Icon: optional icon for a Step.

- Step Content: an optional content of a step.
- Step Button: an optional button of a step.
- Step Icon: an optional icon of a step.
- Step Connector: an optional customized connector of a step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Step Connector: an optional customized connector of a step.
- Step Connector: optional customized connector between Steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Stepper] Missing docs on the StepperContext and StepConnector sub-components
5 participants