Skip to content

feat: add webauthn #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
justin-jiajia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add webauthn #895

justin-jiajia wants to merge 1 commit into from

Conversation

@justin-jiajia
Copy link
Contributor

@justin-jiajia justin-jiajia commented Jan 3, 2026

closes #613

Copilot AI review requested due to automatic review settings January 3, 2026 14:04

This comment was marked as spam.

Sign in to view

@muety muety self-requested a review January 3, 2026 14:45
@muety
Copy link
Owner

muety commented Jan 3, 2026

No idea how Copilot came up with the idea of reviewing this (should be disabled 🤔), but please ignore those comments. I'll give this a review as soon as possible. Thanks for your contribution.

@justin-jiajia
Copy link
Contributor Author

justin-jiajia commented Jan 3, 2026

No idea how Copilot came up with the idea of reviewing this (should be disabled 🤔), but please ignore those comments. I'll give this a review as soon as possible. Thanks for your contribution.

Well I've opened it on my side as I wondered how it worked :)

Don't be that hurry as I'm going to take a exam and maybe work on it again next weekend or later.

BTW: I'm aware that I forgot to use snake-case for attestation json somewhere, and I should brotil the webauthn library too. Will fix them next time I'm free.

@justin-jiajia
Copy link
Contributor Author

justin-jiajia commented Jan 10, 2026

BTW: I'm aware that I forgot to use snake-case for attestation json somewhere, and I should brotil the webauthn library too. Will fix them next time I'm free.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@muety muety Awaiting requested review from muety

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WebAuthn authentication option

2 participants

@justin-jiajia @muety